Changes for Xcode 14, iOS 16, new devices #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS 12 as base deployment
Seems to fix said issue except: - when user pauses and changes tile type - when polyline overlay no longer considered current, as tile overlay keeps becoming the top overlay when map camera changes location - not tested for pre iOS 15 Focus should be at the tile overlay rather than segment overlay it seems.
vincentneo
changed the title
by using constraints for basically everything. fix #233
uses https://github.com/vincentneo/MapCache/tree/ios16-add-overlay-patch fork rather than deployed 0.9 version. special thanks to @Frank-Peter for reporting issue, testing and the extension from ec4edbd#commitcomment-84238460 Co-Authored-By: Frank-Peter <64739349+Frank-Peter@users.noreply.github.com>
resolves 'UI unresponsiveness' warning by Xcode. IMO, too insignificant to deal with alternative methods, such as the recommendation. I did not resolve the other issue at all, since the goal of checking that is to interrupt user when location services is disabled.
|
@vincentneo thank you for this, wouldn't be better if this be merged with |
|
@cs4alhaider I will be merging this to master branch today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
MKCompassButtonimplementation added in fix iOS 15 compass sizing issue #219, to rectify inability to use@availableon lazy variables in Xcode 14