New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade puppeteer #627
Comments
We haven't yet upgraded Puppeteer because we're on the latest version that still supports Node.JS v14 and v16, but we're planning on dropping support for these older Node.JS versions in the next major v11 release, see #618 As a temporary fix, and if you don't mind dropping Node.JS v14/v16 support, you can use your package manager's override feature, e.g. for NPM, you can add the following to your {
"overrides": {
"@mermaid-js/mermaid-cli@^10.6.1": {
"puppeteer": "^21"
}
}
} |
mermaid-filter depends on a deprecated version of puppeteer, which results in puppeteer no longer finding a suitable version of Chromium. See puppeteer/puppeteer#9533 for others facing this issue. Forcing npm to use the most recent release of puppeteer (version 21) resolves this problem. We should revert the workflow to one that doesn't text-insert a dependency and just directly npm installs mermaid-filter once mermaid-js/mermaid-cli#627 has been resolved, a new release of mermaid-cli been produced, and mermaid-filter having picked up that new release.
Is your feature request related to a problem? Please describe.
I'd like to use Puppeteer with Firefox https://hacks.mozilla.org/2023/12/puppeteer-webdriver-bidi/ which requires 21.6.0.
The version currently pinned,
^19.0.0
, is no longer supported:Describe the solution you'd like
mermaid-cli upgrades to a compatible Puppeteer version.
Describe alternatives you've considered
Additional context
I want this for pragmatic reasons but also I want to stop using Chrom{e,ium} everywhere 😉
The text was updated successfully, but these errors were encountered: