Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove dependency on mermaid-mindmap pkg #535

Conversation

aloisklink
Copy link
Member

πŸ“‘ Summary

Since Mermaid v9.4.0, the @mermaid-js/mermaid-mindmap package is no longer needed, since it has been integrated as part of the main mermaid package.

See: https://mermaid.js.org/syntax/mindmap.html#integrating-with-your-library-website
See: mermaid-js/mermaid@71e4f11

Removing this package decreases the size of mermaid-cli's dist/index.html by about 8%!

Before

dist/index.html                          5,241.86 kB β”‚ gzip: 2,148.61 kB

After

dist/index.html                          4,841.83 kB β”‚ gzip: 2,020.65 kB

πŸ“ Design Decisions

N/A

πŸ“‹ Tasks

Make sure you

  • πŸ“– have read the contribution guidelines
  • πŸ’» have added unit/e2e tests (if appropriate)
    • We already have mindmap tests!
  • πŸ”– targeted master branch

Since [Mermaid v9.4.0][1], the `@mermaid-js/mermaid-mindmap` package
is no longer needed, since it has been integrated as part of the main
mermaid package.

See: https://mermaid.js.org/syntax/mindmap.html#integrating-with-your-library-website
See: mermaid-js/mermaid@71e4f11
[1]: https://github.com/mermaid-js/mermaid/releases/tag/v9.4.0
@aloisklink aloisklink added the dependencies Pull requests that update a dependency file label May 3, 2023
@github-actions github-actions bot added the fix label May 3, 2023
@MindaugasLaganeckas MindaugasLaganeckas merged commit 976ce67 into mermaid-js:master May 3, 2023
7 of 8 checks passed
@aloisklink aloisklink deleted the fix/remove-dependency-on-mermaid-mindmap branch May 3, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants