Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links #655

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Update links #655

merged 3 commits into from
Feb 28, 2024

Conversation

BaumiCoder
Copy link
Contributor

📑 Summary

Fix some links the markdown files, which does not work any more.
For two fixes I am not sure, if they are the correct ones:

  1. c9cd49c Is that the correct page for themeCSS❓
  2. 6967591 I chose a relative link to the fork "button". This has the advantage that it still work when the repository moves to another owner or is a fork. The disadvantage is that it does not make any sense at a local working copy of the repository. Locally it links to a file or folder outside of the repository ❗ Would be a static link to https://github.com/mermaid-js/mermaid-cli/fork a better choice ❓

📏 Design Decisions

A working link is better than a broken one 😉

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted master branch

@BaumiCoder
Update link to startpage of website
7ca8b31 
website has moved from  mermaid-js.github.io to mermaid.js.org.
@BaumiCoder
Fix link to themeCSS
c9cd49c 
The old link to mermaid-js.github.io was broken. The redirect does not
lead to a suitable page on the new website.
Using the search of the docs to find the actual page about themeCSS.
@BaumiCoder
Fix link to fork "button"
6967591 
A /fork leads to link on the GitHub webview of the markdown,
which ends with mermaid-cli/blob/master/fork. This is the link 
to a directory called "fork" in root of the repository.
So go back to parent directory, two times, to get mermaid-cli/fork,
which is the link to the fork "button" of the current repository.
@MindaugasLaganeckas
Copy link
Member

Thank you for helping to keep our project nice and clean!

@MindaugasLaganeckas MindaugasLaganeckas merged commit 8a2e906 into mermaid-js:master Feb 28, 2024
6 checks passed
@aloisklink aloisklink added the documentation Improvements or additions to documentation label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BaumiCoder @MindaugasLaganeckas @aloisklink