Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make monaco loading async #1165

Closed
wants to merge 2 commits into from
Closed

Conversation

sidharthv96
Copy link
Member

📑 Summary

Brief description about the content of your PR:

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable:

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@netlify
Copy link

netlify bot commented Feb 24, 2023

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit 96ace2f
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/643fe52ec77eba00081d8f53
😎 Deploy Preview https://deploy-preview-1165--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Feb 24, 2023

Passing run #923 ↗︎

0 27 6 0 Flakiness 0

Details:

Merge 96ace2f into fd189c2...
Project: Mermaid Live Editor Commit: bc133484d1 ℹ️
Status: Passed Duration: 02:19 💡
Started: Apr 19, 2023 12:58 PM Ended: Apr 19, 2023 1:01 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

* develop: (30 commits)
  chore(deps): update all non-major dependencies
  build: update Browserslist db
  fix Test
  chore(deps): update all non-major dependencies
  chore(deps): update node.js to v19
  chore(deps): update dependency jsdom to v21
  chore(deps): update actions/stale action to v8
  chore(deps): update all non-major dependencies
  Bump d3-color from 3.0.1 to 3.1.0
  Did it really work??
  Reduce timeouts
  Splitup tests
  cacheBust loadSite
  Reduce timeout & retries
  Update typeInEditor
  Fix commenting test
  Fix commenting test
  Fix loadSite ?
  Fix commenting test
  Fix branch test
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant