Fix editor broken moving between code and config #1200
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Toggling "Code" and "Config" tabs is broken when you scroll editor
📏 Design Decisions
When changing between tabs scroll top to make sure the current line always makes sense
Before (current prod)
Screen.Recording.2023-04-16.at.15.12.07.mov
After (changes from this PR)
Screen.Recording.2023-04-16.at.15.14.02.mov
📋 Tasks
Make sure you
develop
branch