Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor broken moving between code and config #1200

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

dlitsman
Copy link
Contributor

@dlitsman dlitsman commented Apr 16, 2023

📑 Summary

Toggling "Code" and "Config" tabs is broken when you scroll editor

📏 Design Decisions

When changing between tabs scroll top to make sure the current line always makes sense

Before (current prod)

Screen.Recording.2023-04-16.at.15.12.07.mov
caught Error: Illegal value for lineNumber

Error: Illegal value for lineNumber
    at Bt.getLineMaxColumn (textModel.ts:778:10)
    at _.getViewLineMaxColumn (modelLineProjection.ts:340:16)
    at t.getViewLineMaxColumn (viewModelLines.ts:740:62)
    at v.getLineMaxColumn (viewModelImpl.ts:672:22)
    at new k (viewLinesViewportData.ts:68:16)
    at Q._actualRender (view.ts:393:24)
    at view.ts:364:30
    at se (view.ts:553:10)
    at Q._renderNow (view.ts:364:3)
    at Q._flushAccumulatedAndRenderNow (view.ts:230:8)
    at errors.ts:26:12

After (changes from this PR)

Screen.Recording.2023-04-16.at.15.14.02.mov

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@netlify
Copy link

netlify bot commented Apr 16, 2023

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit a0ccc8f
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/643c03873ab07f0008e02923
😎 Deploy Preview https://deploy-preview-1200--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sidharthv96 sidharthv96 added this pull request to the merge queue Apr 19, 2023
Merged via the queue into mermaid-js:develop with commit 943b458 Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants