Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1401): Handle error when loading gist #1429

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

sidharthv96
Copy link
Member

📑 Summary

Adds try/catch block to supress error when loading gists.

Resolves #1401

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable:

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit 57eef9d
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/660ffc9889a0570008356a60
😎 Deploy Preview https://deploy-preview-1429--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Apr 5, 2024

Passing run #1398 ↗︎

0 29 6 0 Flakiness 0

Details:

Merge 57eef9d into e635b23...
Project: Mermaid Live Editor Commit: 57696355db ℹ️
Status: Passed Duration: 01:45 💡
Started: Apr 5, 2024 1:31 PM Ended: Apr 5, 2024 1:32 PM

Review all test suite changes for PR #1429 ↗︎

@sidharthv96 sidharthv96 merged commit 0e6c022 into develop Apr 5, 2024
11 checks passed
@sidharthv96 sidharthv96 deleted the 1401_LoadGist branch April 5, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load from Gists functionality not working
1 participant