Optimize removeScript

mermaid-js · Jan 25, 2024 · a327068 · a327068
1 parent 3778c41
commit a327068
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/packages/mermaid/src/diagrams/common/common.ts b/packages/mermaid/src/diagrams/common/common.ts
@@ -18,6 +18,13 @@ export const getRows = (s?: string): string[] => {
   return str.split('#br#');
 };
 
+const checkNodeTypeAndGetAttribute = (node: Element, attribute: string) => {
+  if (node.tagName !== 'A') {
+    return null;
+  }
+  return node.getAttribute(attribute);
+};
+
 /**
  * Removes script tags from a text
  *
@@ -30,19 +37,13 @@ export const removeScript = (txt: string): string => {
   if (hasTarget) {
     const TEMPORARY_ATTRIBUTE = 'data-temp-href-target';
     DOMPurify.addHook('beforeSanitizeAttributes', (node: Element) => {
-      if (node.tagName !== 'A') {
-        return;
-      }
-      const target = node.getAttribute(TARGET);
+      const target = checkNodeTypeAndGetAttribute(node, TARGET);
       if (target) {
         node.setAttribute(TEMPORARY_ATTRIBUTE, target);
       }
     });
     DOMPurify.addHook('afterSanitizeAttributes', (node: Element) => {
-      if (node.tagName !== 'A') {
-        return;
-      }
-      const target = node.getAttribute(TEMPORARY_ATTRIBUTE);
+      const target = checkNodeTypeAndGetAttribute(node, TEMPORARY_ATTRIBUTE);
       if (target) {
         node.setAttribute(TARGET, target);
         node.removeAttribute(TEMPORARY_ATTRIBUTE);