Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some logs are out of logLevel #1024

Closed
liyuanqiu opened this issue Oct 23, 2019 · 2 comments
Closed

Some logs are out of logLevel #1024

liyuanqiu opened this issue Oct 23, 2019 · 2 comments
Assignees
@knsv
Labels
Area: Development Graph: State Retained Nonperishable Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect
Projects
8.4.1

Comments

@liyuanqiu
Copy link

Describe the bug
These console.warn are not controlled by logLevel option:
https://github.com/knsv/mermaid/blob/0157f665a305b0616e7932360a2f9fb2fa154668/src/diagrams/state/stateRenderer.js#L281
https://github.com/knsv/mermaid/blob/2da55993e0e7f5a35c8d2b3132d4588c1189a149/src/diagrams/state/shapes.js#L109
They print logs to browser no matter what logLevel is.

To Reproduce

  1. Open state diagram example page: https://mermaidjs.github.io/#/stateDiagram

  2. Open browser console, check the logs at warn level.

⚠️ Diagram node Active stateRenderer.js:281:10
⚠️ 98.68333435058594 32 shapes.js:109:10

Same issue in my own project that uses state diagram.

Expected behavior
Remove those warning logs, or make them be controlled by logLevel.

Screenshots
image

image

Desktop (please complete the following information):

  • OS: [macOS catalina]
  • Browser [Firefox]
  • Version [69]
@liyuanqiu liyuanqiu added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Oct 23, 2019
@knsv knsv added Status: Approved Is ready to be worked on and removed Status: Triage Needs to be verified, categorized, etc labels Oct 23, 2019
@knsv knsv self-assigned this Oct 23, 2019
@knsv knsv added this to To do in 8.4.1 Oct 23, 2019
@knsv knsv moved this from To do to In progress in 8.4.1 Oct 23, 2019
@knsv
Copy link
Collaborator

knsv commented Oct 23, 2019

Thanks @liyuanqiu, I will remove these.

@knsv knsv moved this from In progress to In verification in 8.4.1 Oct 23, 2019
knsv added a commit that referenced this issue Oct 23, 2019
@knsv
#1024 Removal of leftover loggings
c87637c
@knsv knsv moved this from In verification to Ready for release in 8.4.1 Nov 6, 2019
@knsv
Copy link
Collaborator

knsv commented Nov 6, 2019

Part of release 8.4.1

@knsv knsv closed this as completed Nov 6, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@knsv knsv

Labels
Area: Development Graph: State Retained Nonperishable Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect
Projects
No open projects
8.4.1
Ready for release
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IOrlandoni @knsv @liyuanqiu