Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence diagram: long messages cut by the dragram borders #1483

Closed
knsv opened this issue Jun 19, 2020 · 1 comment
Closed

Sequence diagram: long messages cut by the dragram borders #1483

knsv opened this issue Jun 19, 2020 · 1 comment
Labels
Graph: Pie Status: Resolved Type: Bug / Error Something isn't working or is incorrect

Comments

@knsv
Copy link
Collaborator

knsv commented Jun 19, 2020

Describe the bug
After introducing a wrapping mechanism messages without wraps are beeing cut by the edges of the diagram.

image

They used to be rendered like below:
image

To Reproduce
Steps to reproduce the behavior:

sequenceDiagram
   Alice->>Bob:wrap:Extremely utterly long line of longness which had preivously overflown the actor box as it is much longer than what it should be
   Bob->>Alice: I'm short though

Expected behavior
Diagrams with long messages withoutwrap info in the diagram code should be readable for a user without updating the diagram.

I see three solutions to this:

  • Make wrapping is default behaviour
  • Keep the positioning of the participants as the default behaviour and add the option of wrapping

Here is an example of a long message text wrapped:
image

Ideal rendering of this difficult message would actually be a combination of the approaches with the participants separated by some distance and wrapped on two or three lines.

@knsv knsv added Type: Bug / Error Something isn't working or is incorrect Status: Triage Needs to be verified, categorized, etc Graph: Pie and removed Status: Triage Needs to be verified, categorized, etc labels Jun 19, 2020
@jgreywolf
Copy link
Contributor

Closed as resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graph: Pie Status: Resolved Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

No branches or pull requests

2 participants