PR 1482 redux #1484
Merged
PR 1482 redux #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nder cleanup helper dom elements before rendering
1474 missplaced transitions
…ping enabled and disabled
|
Thank, I am glad you took the time. Will merge, then results wil show up here. |
|
Ideally percy should run for all PRs but it only runs for PRs from members. |
|
Ah. I've never had the need to pay for github. Maybe this could be my impetus. |
|
Grr. I thought I had |
|
Found the issue. As always. Simple fix. |
|
Some of the detected changes is due to some fonmt setting that is not set properly. The member thing is beeing a member is mermaid. If you want I can invite you, then you can commit to this branch and percy will trigger without my involvement. If to you our slack channel and ping knsv, then I will invite you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Take a look. I don't have access to Percy (Looks neat) for your project.
I also fixed the issue you saw with loop titles not wrapping. I set the default for loop titles to always wrap no matter what. I'm not sure if this should really be configurable as all it can really do is make the diagram look really bad if it's unwrapped.
Resolves #1483
📏 Design Decisions
Lots and lots of maths.
I added some naughty functions to sequenceDiagram's config object. The merging of config from mermaidAPI/etc should not affect it. The reason for the functions are to simplify getting a font object for calculating text dimensions and for wrapping text.