Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow entity type names to contain spaces, punctuation and other characters #1546

Open
sualeh opened this issue Jul 16, 2020 · 3 comments
Open

Comments

@sualeh
Copy link

sualeh commented Jul 16, 2020

Describe the solution you'd like
Allow entity types to have names in double-quotes, so that they can contain spaces, punctuation and other characters. This way, database table names with space separators can be represented better.

Additional context
This may not be the theoretically "correct" way to name entity types, but practically, we see a lot of examples where people use ER diagrams to represent relational schemas (rather than trying to represent the underlying ER model). Allowing entity type names to contain spaces, punctuation and other characters will expand the user base of mermaid ER diagrams.

@sualeh sualeh added Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request labels Jul 16, 2020
@TreyE TreyE mentioned this issue Feb 1, 2021
3 tasks
@TreyE TreyE mentioned this issue Feb 25, 2021
3 tasks
@IchordeDionysos
Copy link

This would also allow representing arrays like this: string[] which I believe is not even possible now 🤔

joshprice added a commit to joshprice/ash that referenced this issue Sep 12, 2022
joshprice added a commit to joshprice/ash that referenced this issue Sep 28, 2022
joshprice added a commit to joshprice/ash that referenced this issue Sep 28, 2022
joshprice added a commit to joshprice/ash that referenced this issue Oct 2, 2022
@coreybutler
Copy link

It is now possible to have entity names with a space by wrapping it in double quotes. However; this does not work for field types or names because the parser erroneously assumes text wrapped in quotes is a comment.

image

In other words, "CUSTOMER TABLE" renders properly, but the "varchar(250)" and "Custom Field" throw a parsing error.

image

We display two versions of an ERD, one with physical names and the other with logical names. Currently we have to modify the resulting SVG text nodes programmatically to display logical names. While this hack works on websites, it's useless in environments where we cannot control this (i.e. in a Github README).

@AhmedThahir
Copy link

Any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants