Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes around font-family in sccs files makes svgs susceptible to line-wrap corruption #1788

Closed
ahl opened this issue Nov 24, 2020 · 1 comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request

Comments

@ahl
Copy link

ahl commented Nov 24, 2020

Is your feature request related to a problem? Please describe.
When used from https://github.com/asciidoctor/asciidoctor-diagram svgs generated by github.com/mermaid-js/mermaid-cli are line-wrapped which causes them to be corrupted. While clearly asciidoctor-diagram should not be doing this (asciidoctor/asciidoctor-diagram#308) I believe mermaid could make a simple fix to correct this.

Describe the solution you'd like
If the font-family were not surrounded by quotes (") line wrapping in the middle of the name of the default font family (trebuchet ms) seems to be processed fine. I'd propose that themes' sccs files drop the quotes.

Describe alternatives you've considered
Fix asciidoctor-diagram. In the interim, specifying a mermaid config file like this causes the quotes to be dropped:

{
  "fontFamily": "trebuchet ms"
}

Additional context
N/A

@ahl ahl added Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request labels Nov 24, 2020
@knsv
Copy link
Collaborator

knsv commented Nov 26, 2020

Hi, thanks for reporting! Could you please move this report to https://github.com/mermaid-js/mermaid-cli as there are other people working with the cli.

@knsv knsv closed this as completed Nov 26, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants