Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pie Chart to support Themes and configurable slice/section color. #2043

Closed
ashishjain0512 opened this issue May 5, 2021 · 0 comments · Fixed by #2047
Closed

Pie Chart to support Themes and configurable slice/section color. #2043

ashishjain0512 opened this issue May 5, 2021 · 0 comments · Fixed by #2047
Assignees
@ashishjain0512
Labels
Area: Development Graph: Pie Status: Approved Is ready to be worked on Status: In progress Type: Enhancement New feature or request

Comments

@ashishjain0512
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently PieChart used a fixed set of colors from d3, and does not allow change via theme or granular control over each slice color.

Describe the solution you'd like
We should be able to pick different themes, and pie chart colors should also modify. We should have more control to override a given color for a specific section.
@ashishjain0512 ashishjain0512 added Type: Enhancement New feature or request Status: Triage Needs to be verified, categorized, etc labels May 5, 2021
@ashishjain0512 ashishjain0512 self-assigned this May 5, 2021
@ashishjain0512 ashishjain0512 added Area: Development Graph: Pie Status: Approved Is ready to be worked on Status: In progress Topic: Styling and removed Status: Triage Needs to be verified, categorized, etc labels May 5, 2021
ashishjain0512 added a commit that referenced this issue May 5, 2021
@ashishjain0512
#2043 Added PieChart theme variable support
1337ffe
ashishjain0512 added a commit that referenced this issue May 6, 2021
@ashishjain0512
#2043 Added PieChart theme variable support
edb06b1
@ashishjain0512 ashishjain0512 mentioned this issue May 6, 2021
Merged
2 tasks
@knsv knsv closed this as completed in #2047 May 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ashishjain0512 ashishjain0512

Labels
Area: Development Graph: Pie Status: Approved Is ready to be worked on Status: In progress Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pie chart themeing mermaid-js/mermaid
1 participant
@ashishjain0512