Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER-attribute comments not work #2346

Closed
zhengwh opened this issue Sep 27, 2021 · 3 comments · Fixed by #2598
Closed

ER-attribute comments not work #2346

zhengwh opened this issue Sep 27, 2021 · 3 comments · Fixed by #2598
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@zhengwh
Copy link

zhengwh commented Sep 27, 2021

Describe the bug

https://mermaid-js.github.io/mermaid/#/entityRelationshipDiagram?id=attribute-keys-and-comments

Attribute Keys and Comments
Attributes may also have a key or comment defined. Keys can be "PK" or "FK", for Primary Key or Foreign Key. And a comment is defined by quotes at the end of an attribute. Comments themselves cannot have quote characters in them.

but actually it is not work. when i add comments ,the attribute will be hidden in the render graph

@zhengwh zhengwh added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Sep 27, 2021
@linde12
Copy link

linde12 commented Oct 5, 2021

Can confirm. No way to comment and no other way to mark a field as optional/nullable.

As a side note the use of the "PK" or "FK" keys have the same problem as comments!

@ghost
Copy link

ghost commented Oct 6, 2021

N.B. this (if course) affects https://mermaid.live/

@mi-kra
Copy link

mi-kra commented Dec 3, 2021

Column name can't start with "pk", for example:

CUSTOMER {
    string name
    string pkcustNumber
    string sector 
}

it seems to be related problem to above.

ebjornset pushed a commit to ebjornset/mermaid that referenced this issue Dec 29, 2021
ebjornset pushed a commit to ebjornset/mermaid that referenced this issue Dec 29, 2021
ebjornset pushed a commit to ebjornset/mermaid that referenced this issue Dec 29, 2021
ebjornset added a commit to ebjornset/mermaid that referenced this issue Dec 29, 2021
ebjornset added a commit to ebjornset/mermaid that referenced this issue Dec 29, 2021
knsv added a commit that referenced this issue Jan 11, 2022
…d_comments_problems

fix: bug #2346 "ER-attribute comments not work"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants