Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Tooltip #3308

Closed
jpadfield opened this issue Aug 9, 2022 · 2 comments · Fixed by #3331
Closed

Issues with Tooltip #3308

jpadfield opened this issue Aug 9, 2022 · 2 comments · Fixed by #3331
Labels
Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect

Comments

@jpadfield
Copy link

jpadfield commented Aug 9, 2022

I am working with version 9.1.4

I am following the instructions to add tooltips to nodes as part of interactions (https://mermaid-js.github.io/mermaid/#/flowchart?id=interaction), which works well, thanks, but when I had new line tags "< b r / >" into the tooltip they are just rendered as text: https://jsfiddle.net/4wxyv73h/3/

I am initiating the diagram with loose security as required.

The process does work with older versions of Mermaid, such as the 8.4.8, which is used in the instructions demo: https://jsfiddle.net/4wxyv73h/4/

I could not see anything which indicated new settings that needed to be used with the new version of Mermaid, but perhaps I have missed something.

Was this deliberate for some reason or is this a bug?

In general it would be great to have some better examples of CSS to control tool tips, and it might be useful to have an option to add a tooltip without adding a click, or implying a click by adding an empty callback.

Thanks

Joe

@jpadfield jpadfield added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Aug 9, 2022
@knsv knsv added Status: Approved Is ready to be worked on bug and removed Status: Triage Needs to be verified, categorized, etc labels Aug 14, 2022
@knsv
Copy link
Collaborator

knsv commented Aug 14, 2022

There seems to be something wrong! Thanks for reporting.

@knsv
Copy link
Collaborator

knsv commented Aug 14, 2022

A more thorough investigation show that the ability to add tags in tooltips were removed to avoid a few vulnerabilities. BR tags should have an exception though. Will reintroduce the ability to use them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Approved Is ready to be worked on Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants