Breaking change between 9.1.3 and 9.1.4 with Docusaurus #3428
Comments
EugeneLeclerc
added
Status: Triage
|
Does this also affect the latest version of I also had issues upgrading from v9.1.3 to v9.1.4, however this was fixed in v9.1.5. I'm the creator of remark-mermaid-dataurl, which is a similar plugin for adding mermaid to docusaurus (although for docusaurus, |
|
Yes, this behavior is also present in 9.1.5 and 9.1.6. I initially found it by upgrading from 9.1.1 to 9.1.6 and worked backward through the version history to find the breaking point (9.1.3 -> 9.1.4). |
|
OK. First of all we need to reproduce this issue. Any hints on how to go about that would be appreciated. 😄 We then fix the issue in the 9.1.7 release branch, |
|
I will try to create you a sample project with the bug when I get the time in the next few days. Thanks for the answer! |
|
@EugeneLeclerc I managed to reproduce the issue. It has to do with work decoupling the diagrams from the core of Mermaid and with how mdx-mermaid use Mermaid. The decoupled diagrams are loaded when I could make a gitgraph appear when suppling a theme for instance. When I did not supply the config, initialise was never called. I have updated Mermaid so that the loosely coupled diagrams are called even without the |
|
Thanks a lot! |
…lease * origin/release/9.1.7: Release 9.1.7 Fix for broken rendering test Fix for issue #3428, load the configured diagrams even when initialize has not been called.
* sidv/mergeRelease: chore(deps-dev): bump eslint-plugin-jest from 27.0.1 to 27.0.4 (#3458) chore(deps-dev): bump @typescript-eslint/eslint-plugin (#3457) chore(deps-dev): bump concurrently from 7.3.0 to 7.4.0 (#3445) chore(deps-dev): bump @babel/preset-env from 7.18.10 to 7.19.0 (#3442) chore(deps-dev): bump @typescript-eslint/parser from 5.36.1 to 5.37.0 (#3451) chore(deps-dev): bump @babel/core from 7.18.13 to 7.19.0 (#3447) chore(deps-dev): bump jest-environment-jsdom from 29.0.2 to 29.0.3 (#3441) chore(deps-dev): bump babel-jest from 29.0.2 to 29.0.3 (#3448) chore(deps-dev): bump eslint from 8.23.0 to 8.23.1 Release 9.1.7 Fix for broken rendering test Fix for issue #3428, load the configured diagrams even when initialize has not been called.
* develop: Replace GoogleAnalytics with Plausible fix(git): support single character branch names Cleanup unused variables and some commented out code Release 9.1.7 Fix for broken rendering test Fix for issue #3428, load the configured diagrams even when initialize has not been called. #3395 Renabling the error graph which is rendered on error #3395 Fix for lopp stopping at first failure
Hi! I would like to first thank you for Mermaid, I use it a lot and I've been happy with it for a long time.
Describe the bug
I'm using Mermaid with docusaurus (2.1.0) and mdx-mermaid (1.3.2), both latest versions. Between mermaid-js 9.1.3 and 9.1.4, something changed in mermaid-js that broke my Git Graphs. The generated SVG is simply empty, with no error displayed anywhere. I'm conscious the problem may be somewhere in mdx-mermaid, but I did not expect a simple minor version change to change behaviour.
To Reproduce
Steps to reproduce the behavior:
On 9.1.4, the generated SVG is empty:
Expected behavior
I expect the Git Graph to show properly. If there is a problem, I would expect an error showing somewhere. Even if the problem is with mdx-mermaid or docusaurus, I would not expect a patch version change in mermaid-js to break anything.
Platform:
Probably not relevant, but:
Once again, thanks for your work on Mermaid! I do not have time right now to investigate further, but I will try to find the problematic commit later.
The text was updated successfully, but these errors were encountered: