Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier Scans /demos/dev/ failing pnpm tests #5108

Closed
FutzMonitor opened this issue Dec 4, 2023 · 0 comments · Fixed by #5109
Closed

Prettier Scans /demos/dev/ failing pnpm tests #5108

FutzMonitor opened this issue Dec 4, 2023 · 0 comments · Fixed by #5109
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@FutzMonitor
Copy link
Contributor

Description

Currently Prettier checks against the /demos/dev/ directory which causes the tests ran with pnpm test to fail if a file fails. I think it makes sense to check against the example.html file since that's a template that shouldn't change but for any other file there is no benefit to formatting the code properly because they are untracked per the .gitignore file.

Steps to reproduce

  1. Create an HTML file inside of the /demos/dev/ directory. You can simply copy the example.html file and change its name.
  2. Modify the file so that it doesn't abide by Prettier code formatting rules.
  3. Try running pnpm test.
  4. You will notice that the command stops at your file since it doesn't obey the Prettier code formatting rules.

Screenshots

No response

Code Sample

No response

Setup

  • Mermaid version: 10.6.1

Suggested Solutions

Adding some code to the prettierignore file so that the Prettier code formmatter doesn't check the /demos/dev/ directory.

Additional Context

No response

@FutzMonitor FutzMonitor added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant