Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to .prettierignore #5109

Merged
merged 1 commit into from Dec 5, 2023
Merged

Conversation

FutzMonitor
Copy link
Contributor

@FutzMonitor FutzMonitor commented Dec 4, 2023

📑 Summary

Added two lines to the .prettierignore file to ignore running Prettier tests on all files within the /demos/dev/ directory except for the example.html file.

Resolves #5108

📏 Design Decisions

  1. Added 'demos/dev/**' to be ignored by Prettier.
  2. Added '!/demos/dev/example.html' so that Prettier ensures no one changes the example.html in a way that doesn't obey the Prettier code formatting rules.

📋 Tasks

Make sure you

1. Added 'demos/dev/**' to be ignored by Prettier.
2. Added '!/demos/dev/example.html' so that Prettier ensures no one changes the example.html in a way that doesn't obey the Prettier code formatting rules.
Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 11affc3
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/656e3ba6e9482f00087d40e5
😎 Deploy Preview https://deploy-preview-5109--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #5109 (11affc3) into develop (5d56835) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5109      +/-   ##
===========================================
+ Coverage    79.37%   79.40%   +0.02%     
===========================================
  Files          166      166              
  Lines        13876    13876              
  Branches       705      705              
===========================================
+ Hits         11014    11018       +4     
+ Misses        2710     2706       -4     
  Partials       152      152              
Flag Coverage Δ
e2e 85.22% <ø> (+0.03%) ⬆️
unit 43.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@sidharthv96 sidharthv96 added this pull request to the merge queue Dec 5, 2023
Merged via the queue into mermaid-js:develop with commit a9610d3 Dec 5, 2023
18 checks passed
Copy link

mermaid-bot bot commented Dec 5, 2023

@FutzMonitor, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

@FutzMonitor FutzMonitor deleted the issue5108 branch December 5, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettier Scans /demos/dev/ failing pnpm tests
2 participants