Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make link text look like it is on the line #53

Closed
chrisalley opened this issue Dec 12, 2014 · 6 comments
Closed

Make link text look like it is on the line #53

chrisalley opened this issue Dec 12, 2014 · 6 comments
Labels
Type: Enhancement New feature or request

Comments

@chrisalley
Copy link

Could the alternative (or replacement) link text syntax be added?

A-->|Link text|B becomes A--Link Text-->B

And similarly:

A---|Link text|B becomes A--Link Text--B

The reason being that the suggested syntax looks more like it is sitting on the line.

@knsv knsv added the Type: Enhancement New feature or request label Dec 12, 2014
@knsv
Copy link
Collaborator

knsv commented Dec 12, 2014

Again a good suggestion. I link things that makes the graphs more readable. The markdowish approach suggests graphs should be as readable as possible in code without rendering the diagram also.

Will add this one to the list.

Will not do this as a patch release though as this might break backwards compatibility but will add it in a bigger release. Best would be to support both, will see how messy the grammar becomes. Right now there is other activities for example syntax for dotted lines. Will wait until those thing are completed before getting onto this one.

Also... we should have some sort of versioning on the grammar itself and a way of communicating when syntax changes

@knsv
Copy link
Collaborator

knsv commented Dec 27, 2014

I have done some work on this but with small adjustment, a leading space for the text in the links as below:

A---|Link text|B 

becomes

 A-- Link Text --B

knsv added a commit that referenced this issue Dec 27, 2014
@chrisalley
Copy link
Author

Looks good.

@badbye
Copy link

badbye commented Jan 3, 2015

Seems that A-->|Link text|B generate a line instead of a arrow?
Then how to generate a arrow with a link text?

@knsv
Copy link
Collaborator

knsv commented Jan 3, 2015

Hello!

The code below, should generate an arrow:

A-->|Link text|B

This code should generate a line:

A---|Link text|B

When I test this I see the expected behaviour. Can you help me reproduce your problem?

@knsv
Copy link
Collaborator

knsv commented Jan 5, 2015

Released in 0.3.1

@knsv knsv closed this as completed Jan 5, 2015
mgenereu referenced this issue in mgenereu/mermaid Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants