Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1074 Comments documentation #1090

Merged
merged 2 commits into from
Nov 27, 2019

Conversation

jgreywolf
Copy link
Contributor

Adding section to documentation with examples for adding comments in diagrams

Resolves #1074

@jgreywolf
Copy link
Contributor Author

Sorry - I just found https://github.com/mermaidjs/mermaid-gitbook/, should I be updating documentation there instead?

@klemmchr
Copy link
Member

klemmchr commented Nov 27, 2019

Sorry - I just found https://github.com/mermaidjs/mermaid-gitbook/, should I be updating documentation there instead?

Nah, that's absolutely fine. AFAIK the gitbook is not used any more and the docs are generated from the markdown files you adjusted.
LGTM, thanks for your contribution!

@dunning-kruger would be great if you could review this. You're the native speaker in the team 😄

@klemmchr klemmchr changed the title 1074 comments documentation Bug/1074 Comments documentation Nov 27, 2019
@IOrlandoni
Copy link
Member

Thank you very much for your contribution!

@IOrlandoni IOrlandoni merged commit 481e55e into mermaid-js:develop Nov 27, 2019
@jgreywolf jgreywolf deleted the 1074-CommentsDocumentation branch January 7, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants