Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1466 linetypes in beta renderer #1469

Merged
merged 2 commits into from Jun 13, 2020
Merged

1466 linetypes in beta renderer #1469

merged 2 commits into from Jun 13, 2020

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Jun 13, 2020

馃搼 Summary

Add support for line pattern and line width to the new rendering engine.

Resolves #1466

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

@knsv knsv requested a review from ashishjain0512 June 13, 2020 12:04
ashishjain0512
ashishjain0512 approved these changes Jun 13, 2020
View reviewed changes
Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, making it generic will help in other diagrams as well

@knsv knsv merged commit 78e74cd into develop Jun 13, 2020
@knsv knsv deleted the 1466_linetypes_in_beta_renderer branch June 19, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashishjain0512 ashishjain0512 ashishjain0512 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add line type beta rendering of flowcharts
2 participants
@knsv @ashishjain0512