Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mermaidAPI.js #1516

Merged
merged 1 commit into from Jul 2, 2020
Merged

Update mermaidAPI.js #1516

merged 1 commit into from Jul 2, 2020

Conversation

NeilCuzon
Copy link
Member

-Added tables into the comments from mermaidAPI.md, to reflect documentation that I had added through a previous PR, #1509
-as per @knsv 's directions, added comments here.

-also found a list of parameters, who's documentation do not come out in the markdown file. I left them alone, but will be raising a separate issue, for others to review.

-Added tables into the comments from mermaidAPI.md, to reflect documentation that I had added through a previous PR, #1509
-as per @knsv 's directions, added comments here.

-also found a list of parameters, who's documentation do not come out in the markdown file. I left them alone, but will be raising a separate issue, for others to review.
@knsv
Copy link
Collaborator

knsv commented Jul 2, 2020

Hey Neil. I see there are issues in the build here. Don't worry about those, with a code editor this is easily fixed. I will fix that.

@knsv knsv merged commit 891b362 into mermaid-js:develop Jul 2, 2020
@knsv
Copy link
Collaborator

knsv commented Jul 2, 2020

Thanks Neil!

@NeilCuzon
Copy link
Member Author

NeilCuzon commented Jul 3, 2020 via email

@NeilCuzon NeilCuzon deleted the patch-8 branch July 6, 2020 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants