Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed empty code examples #1729

Merged
merged 1 commit into from Oct 15, 2020
Merged

Conversation

Eraledm
Copy link

@Eraledm Eraledm commented Oct 14, 2020

馃搼 Summary

Theming website didn't have mermaid code for the examples shown for sequence diagram and class diagram

Resolves #

馃搹 Design Decisions

I've added the plaintext code above the mermaid code for showing the code on documentation for sequence diagram and class diagram

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@knsv knsv merged commit 561ee5c into mermaid-js:develop Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants