Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

1740 nested subgraps directions #1741

Merged
merged 3 commits into from Oct 22, 2020

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Oct 22, 2020

馃搼 Summary

Brief description about the content of your PR.

Resolves #1740

馃搹 Design Decisions

Adding missed case for determining direction of edge when intersecting a subgraph.

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

@ashishjain0512 ashishjain0512 merged commit 74d09b5 into develop Oct 22, 2020
@ashishjain0512
Copy link
Collaborator

Good Job, the graph looks great in Percy tests

@ashishjain0512 ashishjain0512 deleted the 1740_nested_subgraps_directions branch October 22, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect rendering of nested subgraph
2 participants