Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/update edit this page #1774

Merged
merged 2 commits into from Nov 15, 2020
Merged

Docs/update edit this page #1774

merged 2 commits into from Nov 15, 2020

Conversation

sy-records
Copy link
Contributor

馃搼 Summary

Brief description about the content of your PR.

Add auto generation of Edit this Page.
image

馃搹 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

@GDFaber GDFaber merged commit d54f3af into mermaid-js:develop Nov 15, 2020
@GDFaber
Copy link
Member

GDFaber commented Nov 15, 2020

Looking good. Thank you for your contribution, @sy-records.

@sy-records sy-records deleted the docs/update_edit_this_page branch November 15, 2020 15:17
@GDFaber GDFaber self-requested a review November 15, 2020 15:42
GDFaber
GDFaber reviewed Nov 15, 2020
View reviewed changes
Copy link
Member

@GDFaber GDFaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GDFaber GDFaber GDFaber left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sy-records @GDFaber