Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

2026 fix for descriptions #2030

Merged
merged 3 commits into from Apr 30, 2021
Merged

2026 fix for descriptions #2030

merged 3 commits into from Apr 30, 2021

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Apr 30, 2021

馃搼 Summary

Solves a bug in the new version of state diagrams that prevent long descriptions of state titles for composite states.

Resolves #2026

馃搹 Design Decisions

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

@knsv knsv merged commit 7a90970 into develop Apr 30, 2021
@knsv knsv deleted the 2026_fix_for_descriptions branch July 5, 2021 08:41
@mingfang
Copy link

mingfang commented Dec 3, 2022

This does not completely fix the problem.
The description does not work for nested composite states.

stateDiagram-v2
state "Not Shooting State" as NotShooting {
    state "Not Working" as NotWorking {
        state "Idle mode" as Idle
        state "Configuring mode" as Configuring
        [*] --> Idle
        Idle --> Configuring : EvConfig
        Configuring --> Idle : EvConfig
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composite states using stateDiagram-v2 cant handle descriptions
2 participants