-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: field static classifier #2269
Conversation
Hey, really good work. Much appreciated. We are now moving away from svgDraw (based on d3) to a newer rendering engine based on dagre-wrapper. |
It's done ! Let me know if something is wrongly done. |
Just to be sure, are you aware that dagre seems to indicate it's deprecated? |
For some reason, this currently only works in specific cases: classDiagram
class Person {
String name$
name : String$
name$ : String
name$
}
Person: int age$
Person: age$
Why doesn't it just check, if the line is a field and ends with a It should be more like this: |
Previously, the static classifier was only supported for attributes using the syntax "String name$". Now you can also write "name: String$" See PR mermaid-js#2269 and issue mermaid-js#3001 and my old issue mermaid-js#1953 Further, it was confusing that static/abstract classifiers for methods had to be written after the closing parenthesis of the method signature, even if the method has a return type. So you had to write "foo(name: String)* int". This commit also adds the possibility of writing the classifier at the very end, as in "foo(name: String) int*".
@Dampfwalze There is PR #3855 which addresses your issues. |
馃搼 Summary
The PR allow people to add static field classifier on class fields.
Resolves #1953
馃搹 Design Decisions
No design decisions where needed, I just made it the way it was already made for methods.
馃搵 Tasks
Make sure you
develop
branch