Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live editor tweaks #233

Merged
merged 7 commits into from
Oct 24, 2015
Merged

Live editor tweaks #233

merged 7 commits into from
Oct 24, 2015

Conversation

spect88
Copy link
Collaborator

@spect88 spect88 commented Oct 24, 2015

Hi,

I've tweaked a few things in live editor:

  • Links are encoded with url-safe base64 which makes them easier to understand for arbitrary URL-detecting software like wikis (I've made it backwards compatible though). Might possibly fix Live Editor: Permalink address not being parsed #202?
  • There's another permalink for Edit mode - if you want to share a diagram so that someone else can tweak it and send a new link back
  • Changing the hash in URL (manually, by clicking one of the links or even by navigating back) works without the need for hard refresh
  • Mermaid version is updated to 0.5.5
  • There's a new Download SVG button (fixes Add download SVG link to the live editor #144)

I'm not sure if this is the right place for this PR, but from what I understand there's no build process for this tool, right? If it should go to https://github.com/naseer/mermaid-webapp instead, it'll be pretty easy to port these changes. cc @naseer

@spect88
Get base URL from window.location
4a4335a
@spect88
Add angular-utf8-base64 dependency
aa3cadd
@spect88
Use url-safe base64 encoding for permalinks
eea2ced 
This comes with backwards compatibility.

The motivation is that:

* The new URLs are slightly shorter
* There's a lot of software out there which fails at recognising URLs
  when they contain less common characters, even if perfectly valid.
@spect88
Add another link to edit the diagram
20ac941
@spect88
Support hashchange immediately
7b07202 
Previously the user had to reload (hard) the website after changing hash
URL or clicking one of the permalinks.
@spect88
Update mermaid to 0.5.5 in live editor
62902f9
@spect88
Copy link
Collaborator Author

spect88 commented Oct 24, 2015

Actually, there's something wrong with the way flow graphs look after the update to 0.5.5.
Edit: no, it's fine. It was just a problem with my local setup.

knsv added a commit that referenced this pull request Oct 24, 2015
@knsv
Merge pull request #233 from spect88/live-editor
fdfd7c5 
Live editor tweaks
@knsv knsv merged commit fdfd7c5 into mermaid-js:gh-pages Oct 24, 2015
@knsv
Copy link
Collaborator

knsv commented Oct 24, 2015

Neat with the edit mode. Merging! @naseer I hope you are ok with the changes too.

@naseer
Copy link

naseer commented Oct 24, 2015

👍. Thanks!

mgenereu pushed a commit to mgenereu/mermaid that referenced this pull request Jun 25, 2022
@sidharthv96
Merge pull request mermaid-js#233 from mermaid-js/dependabot/npm_and_…
8cde5eb 
…yarn/develop/prettier-plugin-svelte-2.3.1

Bump prettier-plugin-svelte from 2.3.0 to 2.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spect88 @knsv @naseer