Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

group jison loader and transformer #2369

Merged
merged 1 commit into from
Oct 7, 2021
Merged

group jison loader and transformer #2369

merged 1 commit into from
Oct 7, 2021

Conversation

mmorel-35
Copy link
Contributor

馃搼 Summary

Group the jison loader and transformer in a dedicated folder

馃搹 Design Decisions

I added a validator to the loader.
The transformater uses the parameters from the jest config file.

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Sep 29, 2021 •
edited

I'm wondering if the file should be in jison folder or src/jison folder. Any suggestions?

ashishjain0512
ashishjain0512 approved these changes Oct 7, 2021
View reviewed changes
Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for restructuring

@ashishjain0512 ashishjain0512 merged commit 1c00608 into mermaid-js:develop Oct 7, 2021
@mmorel-35 mmorel-35 deleted the jison branch October 8, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashishjain0512 ashishjain0512 ashishjain0512 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmorel-35 @ashishjain0512