Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added includes; added excludes date background #2423

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

qdechochen
Copy link

馃搼 Summary

feat:
added: includes
added: rect background for exclude dates

馃搹 Design Decisions

includes: similar as exclude, but only support date. includes would override exclude if set a same date. eg.
`
excludes weekends, 2021-10-01,2021-10-04,2021-10-05,2021-10-06,2021-10-07

includes 2021-10-09
`

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, This sure is a nifty feature.

@ashishjain0512 ashishjain0512 merged commit d6a4047 into mermaid-js:develop Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants