-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use monaco-mermaid for syntax highlighting and many syntax highlighting improvements #2449
Conversation
The highlighting works perfectly when a page is loaded for me, but when I navigate to another page using the navbar, highlighting isn't done. Screen.Recording.2021-11-01.at.11.54.34.PM.mov |
The next step you mentioned for removing duplicate is a very welcome addition. As there were issues reported in live editor citing lack of example and it'll free up the maintainers from having to keep the copies in sync. Ref: #2394 (comment) |
Sure I will include that in this PR.
I will look into this. |
@Yash-Singh1 This looks very promising! |
📑 Summary
This changes the syntax highlighting of the documentation:
monaco-mermaid
to highlight code snippets that is Mermaid codemermaid-example
to remove redundant code snippet and diagram scenarios.Related to mermaid-js/mermaid-live-editor#404
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
monaco-editor
andmonaco-mermaid
📋 Tasks
Make sure you
develop
branch