feat: Add chevrotain parser with Unicode support! #3432
Conversation
sidharthv96
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const Text = createToken({ name: 'Text', pattern: /[^\n\r"]+/ }); | ||
| const StringLiteral = createToken({ | ||
| name: 'StringLiteral', | ||
| pattern: /"(:?[^\\"]|\\(:?[bfnrtv"\\/]|u[0-9a-fA-F]{4}))*"/, |
Check failure
Code scanning / CodeQL
Inefficient regular expression
In gitGraph, add support branch names that only have a single character. The branch regex is checking for a starting character, and an ending character, so it currently needs at least two characters. I've wrapped everything except the first character in a `()?` to fix this. There are some really complicated regexes that do match what valid git branches are (see https://stackoverflow.com/a/12093994), but I'm reluctant to add them in, since it will be a pain to test all the different edgecases. Hopefully mermaid-js#3432 might be used in the future to make a better gitgraph parser!
|
This would be great also because it allows for some inheritance. Could hopefully get rid of all the duplication so much of the lexers and parsers. Would also make it easy to implement things that are common to all diagrams (headers, footers, titles, etc.) I wonder if we could use the syntax diagrams in the documentation (e.g. to show the syntax for diagrams) |
|
FYI - I was intrigued by this, so started learning and working with it. When I have it working I'll put up a draft PR. If you want to see what I've got before then, just let me know. |
|
This will come sometime down the line. We are changing a lot right now and we need to stabilize first, after that I will ot this and do a bigger POC for evaluation. |
📑 Summary
Introduces chevrotain as a possible parser instead of JISON with Unicode support!
Experimental support only in the least used Pie and Info diagram.
Related issues
📏 Design Decisions
The new parser has a compatability layer to act as a drop in replacement for the existing JISON parser. So no changes in mermaid code will be required outside of the corresponding diagram's folder.
📋 Tasks
Make sure you
developbranch