-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/4645 graph node containing keyword #4657
Bug/4645 graph node containing keyword #4657
Commits on Jul 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b46c284 - Browse repository at this point
Copy the full SHA b46c284View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3496f27 - Browse repository at this point
Copy the full SHA 3496f27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b987de - Browse repository at this point
Copy the full SHA 5b987deView commit details
Commits on Jul 21, 2023
-
Replace alphanum with NODE_STRING for most usecases
What this allows is for idStrings that are separated by dashes or underscores to be considered one whole string rather than a bunch of tokens mixed together. This is necessary for examples such as a-node-graph[text]. Now, the last part of the idString 'graph' will be read as part of the NODE_STRING token rather than attempting to add a GRAPH token to the idString.
Configuration menu - View commit details
-
Copy full SHA for 7adb1bc - Browse repository at this point
Copy the full SHA 7adb1bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69c91ae - Browse repository at this point
Copy the full SHA 69c91aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d7cc74 - Browse repository at this point
Copy the full SHA 0d7cc74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a4e5f5 - Browse repository at this point
Copy the full SHA 0a4e5f5View commit details -
Remove grammar and unit test that expects HEX token
This was never really used and had many things wrong with it. I believe that if a hex was provided in the diagram specification, the alphanum grammar would break it up into a BRKT and NUM token and use the first line with the addVertex() function. Second, the styleLink grammar provides the exact same functionality with the linkStyle keyword. Third, updateLink() expects an array of nums, not a hex digit. Fourth, no documentation is provided on this grammar statement existing. Fifth, the unit test does not work in version 10.2.4
Configuration menu - View commit details
-
Copy full SHA for 3fa3ed7 - Browse repository at this point
Copy the full SHA 3fa3ed7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ff06e8 - Browse repository at this point
Copy the full SHA 8ff06e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cc8f89 - Browse repository at this point
Copy the full SHA 0cc8f89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20011c6 - Browse repository at this point
Copy the full SHA 20011c6View commit details
Commits on Jul 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for eea0ea5 - Browse repository at this point
Copy the full SHA eea0ea5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f48a9c8 - Browse repository at this point
Copy the full SHA f48a9c8View commit details -
Remove href state and give call higher precedence
Similar to what was done in the class diagram parser, this will allow string tokens to appear in any state. This is especially helpful, because it will simplify the code and any future refactoring
Configuration menu - View commit details
-
Copy full SHA for 3ab0e99 - Browse repository at this point
Copy the full SHA 3ab0e99View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd88b42 - Browse repository at this point
Copy the full SHA fd88b42View commit details
Commits on Jul 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4b9773a - Browse repository at this point
Copy the full SHA 4b9773aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa8e027 - Browse repository at this point
Copy the full SHA fa8e027View commit details -
Configuration menu - View commit details
-
Copy full SHA for 087738d - Browse repository at this point
Copy the full SHA 087738dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 474e0b9 - Browse repository at this point
Copy the full SHA 474e0b9View commit details
Commits on Jul 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 45d9276 - Browse repository at this point
Copy the full SHA 45d9276View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cfbd0d - Browse repository at this point
Copy the full SHA 4cfbd0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 651274b - Browse repository at this point
Copy the full SHA 651274bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 47c1008 - Browse repository at this point
Copy the full SHA 47c1008View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20cd685 - Browse repository at this point
Copy the full SHA 20cd685View commit details -
Correct classDef and class grammar
Previously, you were allowed to define a class called 'default' but were not allowed to use it because the classStatement grammar expected an alphanum, which did not include the word DEFAULT
Configuration menu - View commit details
-
Copy full SHA for 30a9b55 - Browse repository at this point
Copy the full SHA 30a9b55View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd461b7 - Browse repository at this point
Copy the full SHA fd461b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9655ba9 - Browse repository at this point
Copy the full SHA 9655ba9View commit details
Commits on Jul 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1dfb400 - Browse repository at this point
Copy the full SHA 1dfb400View commit details
Commits on Jul 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1df68f9 - Browse repository at this point
Copy the full SHA 1df68f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9eed2e2 - Browse repository at this point
Copy the full SHA 9eed2e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d889742 - Browse repository at this point
Copy the full SHA d889742View commit details
Commits on Jul 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e25763d - Browse repository at this point
Copy the full SHA e25763dView commit details
Commits on Jul 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f269f8c - Browse repository at this point
Copy the full SHA f269f8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bed05ce - Browse repository at this point
Copy the full SHA bed05ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 844f9d9 - Browse repository at this point
Copy the full SHA 844f9d9View commit details -
Remove required space from TAGEND token regex
Originally, I thought this was necessary to prevent parsing the token as part of an edge. I forgot that the token will always be separated from the link/edge by the node id. Added an unit test for an edge case to be certain.
Configuration menu - View commit details
-
Copy full SHA for ed4feae - Browse repository at this point
Copy the full SHA ed4feaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for b545681 - Browse repository at this point
Copy the full SHA b545681View commit details
Commits on Aug 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 834c67e - Browse repository at this point
Copy the full SHA 834c67eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef4f228 - Browse repository at this point
Copy the full SHA ef4f228View commit details -
Modify HREF token regex to contain space
This attempts to maintain the current behaviour. Previously, because HREF contained a space and called a state, the href token was able to be placed in the beginning of node ids (because it wouldn't conflict without the space). We require the space to keep that behaviour.
Configuration menu - View commit details
-
Copy full SHA for e3c5e6f - Browse repository at this point
Copy the full SHA e3c5e6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dc9857 - Browse repository at this point
Copy the full SHA 7dc9857View commit details -
Configuration menu - View commit details
-
Copy full SHA for daf43f8 - Browse repository at this point
Copy the full SHA daf43f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc57fcf - Browse repository at this point
Copy the full SHA dc57fcfView commit details
Commits on Aug 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 199fdce - Browse repository at this point
Copy the full SHA 199fdceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 971215e - Browse repository at this point
Copy the full SHA 971215eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee6fa94 - Browse repository at this point
Copy the full SHA ee6fa94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a165e4 - Browse repository at this point
Copy the full SHA 5a165e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaf3336 - Browse repository at this point
Copy the full SHA aaf3336View commit details -
Configuration menu - View commit details
-
Copy full SHA for 850513f - Browse repository at this point
Copy the full SHA 850513fView commit details
Commits on Aug 4, 2023
-
Add specialChars in textNoTagsToken, alphaNumToken
This will ensure that alphaNumToken does not lose any of the previously used tokens in its definition. The same tokens were added to textNoTagsToken explicitly, because it used to have alphaNumToken in its definition before I removed it. Previously, textNoTagsToken and alphaNumToken had many tokens in common in their definition. To avoid grammar conflicts, the alphaNumStatement grammar was created. However, I found this unintuitive and was an extra step just to avoid repetition in the definitions. I opted to have repetition in the definitions of textNoTagsToken and alphaNumToken and it be explicitly clear right away, rather than have extra grammar statements like alphaNumStatement which don't look like they do anything at first glance
Configuration menu - View commit details
-
Copy full SHA for c9db0ee - Browse repository at this point
Copy the full SHA c9db0eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34bf618 - Browse repository at this point
Copy the full SHA 34bf618View commit details