Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/4645 graph node containing keyword #4657

Commits on Jul 20, 2023

  1. Configuration menu
    Copy the full SHA
    b46c284 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3496f27 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5b987de View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Replace alphanum with NODE_STRING for most usecases

    What this allows is for idStrings that are separated by
    dashes or underscores to be considered one whole string
    rather than a bunch of tokens mixed together.
    
    This is necessary for examples such as a-node-graph[text].
    Now, the last part of the idString 'graph' will be read as
    part of the NODE_STRING token rather than attempting to add
    a GRAPH token to the idString.
    ibrahimWassouf committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    7adb1bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    69c91ae View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0d7cc74 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0a4e5f5 View commit details
    Browse the repository at this point in the history
  5. Remove grammar and unit test that expects HEX token

    This was never really used and had many things wrong with it.
    I believe that if a hex was provided in the diagram specification,
    the alphanum grammar would break it up into a BRKT and NUM token
    and use the first line with the addVertex() function.
    
    Second, the styleLink grammar provides the exact same functionality
    with the linkStyle keyword.
    
    Third, updateLink() expects an array of nums, not a hex digit.
    
    Fourth, no documentation is provided on this grammar statement existing.
    Fifth, the unit test does not work in version 10.2.4
    ibrahimWassouf committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    3fa3ed7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8ff06e8 View commit details
    Browse the repository at this point in the history
  7. Add edgeText states

    ibrahimWassouf committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    0cc8f89 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    20011c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. Configuration menu
    Copy the full SHA
    eea0ea5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f48a9c8 View commit details
    Browse the repository at this point in the history
  3. Remove href state and give call higher precedence

    Similar to what was done in the class diagram parser,
    this will allow string tokens to appear in any state.
    This is especially helpful, because it will simplify the
    code and any future refactoring
    ibrahimWassouf committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    3ab0e99 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fd88b42 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Configuration menu
    Copy the full SHA
    4b9773a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa8e027 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    087738d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    474e0b9 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Configuration menu
    Copy the full SHA
    45d9276 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4cfbd0d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    651274b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    47c1008 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    20cd685 View commit details
    Browse the repository at this point in the history
  6. Correct classDef and class grammar

    Previously, you were allowed to define a class called 'default'
    but were not allowed to use it because the classStatement grammar
    expected an alphanum, which did not include the word DEFAULT
    ibrahimWassouf committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    30a9b55 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fd461b7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9655ba9 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Configuration menu
    Copy the full SHA
    1dfb400 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Configuration menu
    Copy the full SHA
    1df68f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9eed2e2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d889742 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Configuration menu
    Copy the full SHA
    e25763d View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. Configuration menu
    Copy the full SHA
    f269f8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bed05ce View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    844f9d9 View commit details
    Browse the repository at this point in the history
  4. Remove required space from TAGEND token regex

    Originally, I thought this was necessary to prevent parsing
    the token as part of an edge. I forgot that the token will always
    be separated from the link/edge by the node id. Added an unit test
    for an edge case to be certain.
    ibrahimWassouf committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    ed4feae View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b545681 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Configuration menu
    Copy the full SHA
    834c67e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ef4f228 View commit details
    Browse the repository at this point in the history
  3. Modify HREF token regex to contain space

    This attempts to maintain the current behaviour.
    Previously, because HREF contained a space and called
    a state, the href token was able to be placed in the
    beginning of node ids (because it wouldn't conflict
    without the space). We require the space to keep that
    behaviour.
    ibrahimWassouf committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    e3c5e6f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7dc9857 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    daf43f8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dc57fcf View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Configuration menu
    Copy the full SHA
    199fdce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    971215e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ee6fa94 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5a165e4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    aaf3336 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    850513f View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Add specialChars in textNoTagsToken, alphaNumToken

    This will ensure that alphaNumToken does not lose any of
    the previously used tokens in its definition. The same
    tokens were added to textNoTagsToken explicitly, because it used to
    have alphaNumToken in its definition before I removed it.
    
    Previously, textNoTagsToken and alphaNumToken had many tokens in
    common in their definition. To avoid grammar conflicts, the
    alphaNumStatement grammar was created. However, I found this
    unintuitive and was an extra step just to avoid repetition in
    the definitions.
    
    I opted to have repetition in the definitions of textNoTagsToken
    and alphaNumToken and it be explicitly clear right away, rather than
    have extra grammar statements like alphaNumStatement which don't look
    like they do anything at first glance
    ibrahimWassouf committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    c9db0ee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34bf618 View commit details
    Browse the repository at this point in the history