Gantt - Add target in links #4695
Open
+147
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tsx instead of ts-node-esm
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4695 +/- ##
===========================================
- Coverage 45.32% 45.30% -0.03%
===========================================
Files 52 52
Lines 6645 6651 +6
Branches 18 18
===========================================
+ Hits 3012 3013 +1
- Misses 3633 3638 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sidharthv96
reviewed
Aug 10, 2023
Comment on lines
-36
to
+39
| "docs:release-version": "ts-node-esm scripts/update-release-version.mts", | ||
| "docs:verify-version": "ts-node-esm scripts/update-release-version.mts --verify", | ||
| "types:build-config": "ts-node-esm --transpileOnly scripts/create-types-from-json-schema.mts", | ||
| "types:verify-config": "ts-node-esm scripts/create-types-from-json-schema.mts --verify", | ||
| "docs:release-version": "tsx scripts/update-release-version.mts", | ||
| "docs:verify-version": "tsx scripts/update-release-version.mts --verify", | ||
| "types:build-config": "tsx --transpileOnly scripts/create-types-from-json-schema.mts", | ||
| "types:verify-config": "tsx scripts/create-types-from-json-schema.mts --verify", |
There was a problem hiding this comment.
Can you please move the changes related to npx and tsx to another PR?
We've had issues when using tsx in the past.
sidharthv96
requested changes
Aug 10, 2023
Comment on lines
-620
to
+626
| links[id] = linkStr; | ||
| links[id] = [linkStr, target]; |
There was a problem hiding this comment.
Don't use arrays, use objects, so it's clear when using the values.
links[id] = {link: linkStr, target};
Comment on lines
+45
to
+53
| "_self" return 'hreftarget'; | ||
| \"_self\" return 'hreftarget'; | ||
| "_blank" return 'hreftarget'; | ||
| \"_blank\" return 'hreftarget'; | ||
| "_parent" return 'hreftarget'; | ||
| \"_parent\" return 'hreftarget'; | ||
| "_top" return 'hreftarget'; | ||
| \"_top\" return 'hreftarget'; | ||
|
|
There was a problem hiding this comment.
"_self" return 'LINK_TARGET';
"_blank" return 'LINK_TARGET';
"_parent" return 'LINK_TARGET';
"_top" return 'LINK_TARGET';
This is from flow.jison.
Why do we need the duplicates with escaped quotes?
|
@ykatchou waiting for your updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
In order to all links within gantt chart to open in a new tab (or allow a new target) i did add the target options to links.
Resolves #3326
📏 Design Decisions
As discussed in the issue #3326 , i did base my change on the changes done on flowchart in #1585.
I did limit the usage of target to the main case of a simple url.
As I’m not a js dev, i did start from a "clean" env.
To make the dev env works, I did need to do some slight changes.
Those changes were done in a dedicated commit (the first one) :
Those changes were done in a dedicated commit (the first one), feel free to revert those.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch