Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live reload #4726

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Live reload #4726

merged 1 commit into from
Aug 13, 2023

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Aug 12, 2023

📑 Summary

Adds live reload to the esbuild development server. Will make the lives of devs easier :)
Uses Server Sent Events

Resolves #

📏 Design Decisions

Could not use esbuild's watch as the rebuild events were not available easily.
Chokidar is already used to watch docs, so not an extra dependency.

📋 Tasks

Make sure you

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Merging #4726 (0a0db87) into sidv/esbuildV10 (43217e1) will decrease coverage by 25.49%.
Report is 49 commits behind head on sidv/esbuildV10.
The diff coverage is n/a.

❗ Current head 0a0db87 differs from pull request most recent head 5e21075. Consider uploading reports for the commit 5e21075 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           sidv/esbuildV10    #4726       +/-   ##
====================================================
- Coverage            71.57%   46.09%   -25.49%     
====================================================
  Files                  116       53       -63     
  Lines                12709     6736     -5973     
  Branches               549       32      -517     
====================================================
- Hits                  9097     3105     -5992     
- Misses                3495     3630      +135     
+ Partials               117        1      -116     
Flag Coverage Δ
e2e ?
unit 46.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 111 files with indirect coverage changes

Copy link
Member

@Yokozuna59 Yokozuna59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions.

package.json Outdated Show resolved Hide resolved
demos/dev/example.html Outdated Show resolved Hide resolved
.esbuild/server.ts Show resolved Hide resolved
Copy link
Member

@Yokozuna59 Yokozuna59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

.esbuild/server.ts Show resolved Hide resolved
@sidharthv96 sidharthv96 changed the base branch from sidv/esbuildV10 to sidv/esbuildV11 August 13, 2023 13:21
@sidharthv96 sidharthv96 self-assigned this Aug 13, 2023
@sidharthv96 sidharthv96 merged commit 88818b4 into sidv/esbuildV11 Aug 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants