Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11] Limit MermaidConfig enum TypesScript types to certain values #4803

Merged
merged 2 commits into from
Sep 3, 2023
Merged

[v11] Limit MermaidConfig enum TypesScript types to certain values #4803

merged 2 commits into from
Sep 3, 2023

Commits on Sep 2, 2023

  1. test: rewrite some config vals to tighten types 

    We're planning on limiting some of MermaidConfig's types to specific
values (e.g. `0 | 1` instead of `number`).
    @aloisklink
    aloisklink committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    77ba7c9 View commit details
    Browse the repository at this point in the history

  2. refactor!: remove MermaidConfig type enum fallback 

    Currently (in Mermaid v10), pretty much all enum types in the
MermaidConfig have generic `string` or `number` fallbacks,
for backwards compatibility.

This commit drops this. The MermaidConfig TypeScript types now expects
a limited amount of values.

BREAKING-CHANGE: Remove `MermaidConfig` generic type fallbacks for
                 enum values.
    @aloisklink
    aloisklink committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    b48136d View commit details
    Browse the repository at this point in the history