Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add light syntax highlighting theme #4998

Closed
wants to merge 1 commit into from

Conversation

huynhicode
Copy link
Member

πŸ“‘ Summary

This PR adds light syntax highlighting to the code block theme. No changes to dark mode.

See screenshots:

Screenshot 2023-10-29 at 8 21 45 PM Screenshot 2023-10-29 at 8 17 21 PM Screenshot 2023-10-29 at 8 17 29 PM

Resolves #4971

πŸ“ Design Decisions

n/a

πŸ“‹ Tasks

Make sure you

@netlify
Copy link

netlify bot commented Oct 30, 2023

βœ… Deploy Preview for mermaid-js ready!

Name Link
πŸ”¨ Latest commit dc2373e
πŸ” Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/653f2263ffe3f200082576fe
😎 Deploy Preview https://deploy-preview-4998--mermaid-js.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@huynhicode huynhicode requested a review from knsv October 30, 2023 03:26
@huynhicode huynhicode changed the base branch from develop to master October 30, 2023 03:26
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #4998 (dc2373e) into master (f1895ac) will increase coverage by 1.10%.
Report is 345 commits behind head on master.
The diff coverage is 75.02%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4998      +/-   ##
==========================================
+ Coverage   76.03%   77.14%   +1.10%     
==========================================
  Files         146      164      +18     
  Lines       14569    13820     -749     
  Branches      592      693     +101     
==========================================
- Hits        11078    10661     -417     
+ Misses       3368     3003     -365     
- Partials      123      156      +33     
Flag Coverage Ξ”
e2e 82.45% <86.42%> (-0.11%) ⬇️
unit 42.94% <25.39%> (-2.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
packages/mermaid/src/config.ts 68.82% <100.00%> (-5.67%) ⬇️
packages/mermaid/src/dagre-wrapper/clusters.js 87.25% <ΓΈ> (-0.99%) ⬇️
packages/mermaid/src/dagre-wrapper/createLabel.js 92.85% <ΓΈ> (ΓΈ)
packages/mermaid/src/dagre-wrapper/index.js 98.82% <100.00%> (ΓΈ)
packages/mermaid/src/dagre-wrapper/markers.js 100.00% <100.00%> (ΓΈ)
...ages/mermaid/src/dagre-wrapper/mermaid-graphlib.js 90.95% <100.00%> (ΓΈ)
packages/mermaid/src/dagre-wrapper/nodes.js 78.36% <100.00%> (-11.26%) ⬇️
packages/mermaid/src/dagre-wrapper/shapes/note.js 100.00% <ΓΈ> (ΓΈ)
packages/mermaid/src/dagre-wrapper/shapes/util.js 96.22% <ΓΈ> (ΓΈ)
packages/mermaid/src/defaultConfig.ts 47.98% <100.00%> (+0.77%) ⬆️
... and 73 more

... and 26 files with indirect coverage changes

@huynhicode
Copy link
Member Author

Looks like a similar PR was submitted on Oct 7th by a community member.

PR-4924 to resolve issue 4905

Closing my PR as it is a duplicate and was submitted after 4924.

@huynhicode huynhicode closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples Illegible in Docs Without Highlighting
3 participants