-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to Gantt Parsers to allow hashes and semicolons to titles, sections, and task data. #5095
Merged
Commits on Dec 2, 2023
-
1. Removed the hash and semicolon symbols from the title regex to allow for their use. 2. Removed the hash and semicolon symbols from the section regex to allow for their use. 3. Removed the hash and semicolon symbols for the taskTxt regex to allow for their use. I did not remove the colon because the parser fails to recognize when the actual taskData begins if that distinctions isn't kept. 4. Removed the regex \#[^\n]* which skipped comments to fix some bugs with hash symbols in the taskTxt. I tested this changed by putting it back and using the comment to see if it was recognized as a comment, but I would receive a syntax error and the diagram would not be rendered. So, I think we can safely remove that line, BUT it would be best practice if someone else tested this change to ensure that this will not break anyone's Gantt diagrams.
Configuration menu - View commit details
-
Copy full SHA for f02dfe6 - Browse repository at this point
Copy the full SHA f02dfe6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68ff352 - Browse repository at this point
Copy the full SHA 68ff352View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e95cdb - Browse repository at this point
Copy the full SHA 8e95cdbView commit details
Commits on Dec 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for aa3a19b - Browse repository at this point
Copy the full SHA aa3a19bView commit details
Commits on Dec 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 03b5c00 - Browse repository at this point
Copy the full SHA 03b5c00View commit details
Commits on Jan 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c080522 - Browse repository at this point
Copy the full SHA c080522View commit details
Commits on Jan 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0b0f988 - Browse repository at this point
Copy the full SHA 0b0f988View commit details
Commits on Jan 26, 2024
-
1. Added a Gantt diagram that demonstrates to users that hashtages and semicolons can be added to titles, sections, and task data. Changes to gantt.spec.js 1. Added unit tests to ensure that semicolons and hashtags didn't break the functionality of the gantt diagram when used in titles, sections or task data. Changes to /parser/gantt.spec.js 1. Added rendering tests to ensure that semicolons and hashtags in titles, sections, and task data didn't break the rendering of Gantt diagrams.
Configuration menu - View commit details
-
Copy full SHA for 59264a3 - Browse repository at this point
Copy the full SHA 59264a3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.