Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Gantt Parsers to allow hashes and semicolons to titles, sections, and task data. #5095

Merged
merged 8 commits into from
Jan 26, 2024

Commits on Dec 2, 2023

  1. Changes to gnatt.jison

    1. Removed the hash and semicolon symbols from the title regex to allow for their use.
    2. Removed the hash and semicolon symbols from the section regex to allow for their use.
    3. Removed the hash and semicolon symbols for the taskTxt regex to allow for their use. I did not remove the colon because the parser fails to recognize when the actual taskData begins if that distinctions isn't kept.
    4. Removed the regex \#[^\n]* which skipped comments to fix some bugs with hash symbols in the taskTxt. I tested this changed by putting it back and using the comment  to see if it was recognized as a comment, but I would receive a syntax error and the diagram would not be rendered. So, I think we can safely remove that line, BUT it would be best practice if someone else tested this change to ensure that this will not break anyone's Gantt diagrams.
    FutzMonitor committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    f02dfe6 View commit details
    Browse the repository at this point in the history
  2. Changes to gantt.jison

    1. Removed typo
    FutzMonitor committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    68ff352 View commit details
    Browse the repository at this point in the history
  3. Changes to gantt.jison

    1. Consistent spacing on line 30
    FutzMonitor committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    8e95cdb View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2023

  1. Configuration menu
    Copy the full SHA
    aa3a19b View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Configuration menu
    Copy the full SHA
    03b5c00 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Configuration menu
    Copy the full SHA
    c080522 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    0b0f988 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Changes to gantt.html

    1. Added a Gantt diagram that demonstrates to users that hashtages and semicolons can be added to titles, sections, and task data.
    Changes to gantt.spec.js
    1. Added unit tests to ensure that semicolons and hashtags didn't break the functionality of the gantt diagram when used in titles, sections or task data.
    Changes to /parser/gantt.spec.js
    1. Added rendering tests to ensure that semicolons and hashtags in titles, sections, and task data didn't break the rendering of Gantt diagrams.
    FutzMonitor committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    59264a3 View commit details
    Browse the repository at this point in the history