Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with generic class not rendering #5098

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

jgreywolf
Copy link
Contributor

📑 Summary

Updated addClassesToNamespace function to split the classname/type to ensure correct item is being assigned to namespace

Resolves #4578

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 761fa27
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/656d6922582ca20008df0ab2
😎 Deploy Preview https://deploy-preview-5098--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #5098 (761fa27) into develop (f81e4d4) will decrease coverage by 2.30%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5098      +/-   ##
===========================================
- Coverage    79.41%   77.12%   -2.30%     
===========================================
  Files          166      166              
  Lines        13871    13873       +2     
  Branches       705      705              
===========================================
- Hits         11016    10699     -317     
- Misses        2703     3015     +312     
- Partials       152      159       +7     
Flag Coverage Δ
e2e 82.38% <66.66%> (-2.86%) ⬇️
unit 43.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/diagrams/class/classDb.ts 82.47% <66.66%> (+8.51%) ⬆️

... and 22 files with indirect coverage changes

Copy link
Member

@sidharthv96 sidharthv96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some unit tests? Added.

@sidharthv96 sidharthv96 added this to the v10 milestone Dec 4, 2023
@sidharthv96 sidharthv96 added this pull request to the merge queue Dec 4, 2023
Merged via the queue into develop with commit 886405b Dec 4, 2023
25 of 26 checks passed
@sidharthv96 sidharthv96 deleted the 4578-generic-class-in-namespace branch December 4, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic class syntax throws error when nested in namespace
2 participants