Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NiceGuy.io links in integrations-community.md #5120

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

Abrifq
Copy link
Contributor

@Abrifq Abrifq commented Dec 6, 2023

📑 Summary

I got notified from my fork that the niceguy's links were not working, looks like they updated their sitemap and this PR updates the relevant parts!

Resolves: link checker fails about niceguy dot io

📏 Design Decisions

Updated the links.

📋 Tasks

Make sure you

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit f476c25
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/657104c54fa895000849784a
😎 Deploy Preview https://deploy-preview-5120--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #5120 (1d08155) into develop (cc4af0c) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 1d08155 differs from pull request most recent head f476c25. Consider uploading reports for the commit f476c25 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5120      +/-   ##
===========================================
+ Coverage    79.37%   79.40%   +0.02%     
===========================================
  Files          166      166              
  Lines        13877    13877              
  Branches       705      705              
===========================================
+ Hits         11015    11019       +4     
+ Misses        2710     2706       -4     
  Partials       152      152              
Flag Coverage Δ
e2e 85.22% <ø> (+0.03%) ⬆️
unit 43.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@sidharthv96 sidharthv96 merged commit 4f9988a into mermaid-js:develop Dec 7, 2023
4 checks passed
@Abrifq
Copy link
Contributor Author

Abrifq commented Dec 7, 2023

Thanks for merging! Can someone on team check mermaid-js/mermaid-live-editor#1335 as well?

Having the docs in the editor is important (as always) and I don't want this PR to go stale.

Have a nice week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants