-
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Semicolons in Timeline Titles, Sections, Periods, and Events #5335
Open
FutzMonitor
wants to merge
7
commits into
mermaid-js:develop
Choose a base branch
from
FutzMonitor:4175Issue-allowSemicolons
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Allow Semicolons in Timeline Titles, Sections, Periods, and Events #5335
FutzMonitor
wants to merge
7
commits into
mermaid-js:develop
from
FutzMonitor:4175Issue-allowSemicolons
Commits on Feb 27, 2024
-
1. Removed the semicolon from the regex for titles, sections, periods, and events. Changes to timeline.spec.js 1. Added a test for the changes made in the timeline parser
Configuration menu - View commit details
-
Copy full SHA for 1169cb9 - Browse repository at this point
Copy the full SHA 1169cb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f13beab - Browse repository at this point
Copy the full SHA f13beabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e3ebf1 - Browse repository at this point
Copy the full SHA 9e3ebf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for fab6987 - Browse repository at this point
Copy the full SHA fab6987View commit details
Commits on Mar 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e433b95 - Browse repository at this point
Copy the full SHA e433b95View commit details
Commits on Mar 19, 2024
-
1. Re-organized the new TL-6 test to not use a for-loop with a switch case. 2. Imported the commonDb module to ensure titles are be tested. 3. Use indices to retrieve elements that need to be tested.
Configuration menu - View commit details
-
Copy full SHA for cf88f06 - Browse repository at this point
Copy the full SHA cf88f06View commit details
Commits on Mar 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c239b6e - Browse repository at this point
Copy the full SHA c239b6eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.