Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup Argos Visual Testing #5577

Merged
merged 7 commits into from
Jun 20, 2024

Conversation

gregberge
Copy link
Contributor

📑 Summary

As discussed with @sidharthv96, I setup Argos Visual Testing. At some point you should be able to replace Applitools without any limitation of usage.

📏 Design Decisions

I kept Applitools and cy.matchImageSnapshot, you should be able to remove it once Argos fits your need!

📋 Tasks

Make sure you

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 1f70717
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6673f2f8a702ae0008e0644f
😎 Deploy Preview https://deploy-preview-5577--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.73%. Comparing base (0044aa3) to head (e951560).

Current head e951560 differs from pull request most recent head 1f70717

Please upload reports for the commit 1f70717 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5577      +/-   ##
==========================================
- Coverage     5.73%   5.73%   -0.01%     
==========================================
  Files          277     278       +1     
  Lines        41988   41999      +11     
  Branches       515     490      -25     
==========================================
  Hits          2409    2409              
- Misses       39579   39590      +11     
Flag Coverage Δ
unit 5.73% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link

argos-ci bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Waiting for the first build to start…

@gregberge
Copy link
Contributor Author

@sidharthv96 @knsv could you give a look?

@gregberge
Copy link
Contributor Author

@sidharthv96 how can I help?

@mermaid-js mermaid-js deleted a comment from nirname Jun 20, 2024
@mermaid-js mermaid-js deleted a comment from gregberge Jun 20, 2024
@mermaid-js mermaid-js deleted a comment from gregberge Jun 20, 2024
@mermaid-js mermaid-js deleted a comment from nirname Jun 20, 2024
@mermaid-js mermaid-js deleted a comment from gregberge Jun 20, 2024
* develop:
  Removed unused patch
  Fix cytoscape patch
  chore: Remove cytoscape patch.
  docs: fix node version in CONTRIBUTING.md
  Fixed entrypoint path
@sidharthv96 sidharthv96 merged commit 85628f2 into mermaid-js:develop Jun 20, 2024
16 of 18 checks passed
Copy link

mermaid-bot bot commented Jun 20, 2024

@gregberge, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants