Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class based styling #62

Merged
merged 6 commits into from Dec 14, 2014
Merged

Class based styling #62

merged 6 commits into from Dec 14, 2014

Conversation

bjowes
Copy link
Contributor

@bjowes bjowes commented Dec 14, 2014

Changes the previous concept of inline styling to class based styling. The class definitions are placed into a style element, added at the top of the SVG structure. This preserves the aspect of keeping the SVG copy&paste-able without losing the styling. It also allows usage of external CSS style sections to define the classes used in the graphs.
Limitations:

  • This only works for styling of nodes, but this is also the only case where classes where available in the syntax.
  • Not implemented for sequence diagrams

Resolves issue #24.

bjowes and others added 6 commits December 13, 2014 21:24
Removed the inline styling of nodes with classes, replaced with class
attributes and a common CSS Style section at the start of the SVG.
Added unit testing
classDefs are now exported to the common style of the SVG
Styling is no longer copied from other mermaid SVGs on the same webpage
Conflicts:
	.gitignore
	dist/mermaid.full.min.js
	dist/mermaid.slim.min.js
knsv added a commit that referenced this pull request Dec 14, 2014
@knsv knsv merged commit 13a65db into mermaid-js:master Dec 14, 2014
@knsv
Copy link
Collaborator

knsv commented Dec 14, 2014

Merged! Thanks for your work!

@klemmchr klemmchr added the Skip changelog Don't include in the changelog label Dec 4, 2019
mgenereu referenced this pull request in mgenereu/mermaid Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip changelog Don't include in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants