#478 API crashes on 2nd render() call

[KoljaTM]

Resolves #478

Remove element from DOM before rendering to avoid conflicts in case of rerendering

[coveralls]

Pull Request Test Coverage Report for Build 1103

• 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.03%) to 52.813%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/mermaidAPI.js	0	3	0.0%

Totals
Change from base Build 1097:	-0.03%
Covered Lines:	3067
Relevant Lines:	5715

---

💛 - Coveralls

[IOrlandoni]

Is there any way we could set up a test for this? Either unit or e2e...

[KoljaTM]

I have looked a bit into it, the problem is that we don't have the real document object at hand and therefore the d3.select(...).node() function doesn't exist. At the moment, there don't seem to be tests for the render(), at least no unit-tests. I can give it another look and if unit doesn't work out, add something to the e2e tests.

[IOrlandoni]

Pending confirmation of the person who had the issue assigned to them.

[klemmchr]

Your pr includes a commit from knsv about font configuration stuff, could you rebase your branch/cherrypick the relevant commit and create a new branch from develop? knsv was that nice to write a CONTRIBUTING.md recently, you might want to have a look into it.
TL;DR this will be merged to develop

[KoljaTM]

OK sure, no problem

[KoljaTM]

I added an e2e test now. It works (and fails when I take my change out). It seems that the width of the graph is not determined correctly though. No idea where that comes from, but it doesn't seem related to this bug.

[klemmchr]

This could be related to the commit of knsv regarding font size configuration that you included in this pr. It needs to be removed from this pr.

[knsv]

The issue with the clipped text has to do with different styling applied during rendering compared with font applied when the graph is put in to place after rendering. The font-family fix should handle that problem, and has just been merged to develop. I have reviewed this and will merge it.

My only concern is if there are some use-case where this might break some integration...

[klemmchr]

There might be cases that rely on the current behavior but I would consider that as a misuse of the functionality.

[knsv]

Merging but it will not be inkclud in 8.4.0. next release though.