Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message Line Misalignment in Sequence Diagram #89

Closed
MrCoder opened this issue Nov 20, 2023 · 3 comments · Fixed by #92
Closed

Message Line Misalignment in Sequence Diagram #89

MrCoder opened this issue Nov 20, 2023 · 3 comments · Fixed by #92
Assignees
Labels
bug Something isn't working renderer

Comments

@MrCoder
Copy link
Collaborator

MrCoder commented Nov 20, 2023

image

Code to reproduce this issue:

// Issue #88
A->A.method {
  // [bold, red]Issue #89
  B:async message
}

This issue may be related to #88 .

@MrCoder MrCoder added bug Something isn't working renderer labels Nov 20, 2023
@MrCoder
Copy link
Collaborator Author

MrCoder commented Nov 20, 2023

There is a similar scenario when this issue occurs.

image

A.method() {
  B:method
  self() {
    // [bold, red] similar issue
    B:method
  }
}

unimu-cic added a commit that referenced this issue Nov 21, 2023
@unimu-cic unimu-cic linked a pull request Nov 21, 2023 that will close this issue
MrCoder added a commit that referenced this issue Nov 21, 2023
@MrCoder
Copy link
Collaborator Author

MrCoder commented Nov 21, 2023

The PRs have fixed a couple of issues, but it introduced a regression on this following case.

A->B:message
Screenshot 2023-11-22 at 10 46 35 am

Note, sync message works fine.

A->B.method
Screenshot 2023-11-22 at 10 48 35 am

@MrCoder MrCoder reopened this Nov 21, 2023
@MrCoder
Copy link
Collaborator Author

MrCoder commented Nov 21, 2023

One more example:

A->B.method {
  // [red, bold] issue #89
  A:method
}
Screenshot 2023-11-22 at 10 51 12 am

unimu-cic added a commit that referenced this issue Nov 25, 2023
unimu-cic added a commit that referenced this issue Nov 25, 2023
unimu-cic added a commit that referenced this issue Nov 28, 2023
unimu-cic added a commit that referenced this issue Nov 28, 2023
unimu-cic added a commit that referenced this issue Dec 4, 2023
MrCoder added a commit that referenced this issue Dec 7, 2023
@MrCoder MrCoder closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working renderer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants