Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dockerfile and documentation #63

Merged
merged 3 commits into from Nov 17, 2019
Merged

Added Dockerfile and documentation #63

merged 3 commits into from Nov 17, 2019

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented Oct 6, 2019

  • Final image size of 11.8MB based on Docker Scratch (empty image, no OS)
  • Multi stage build for a smaller image size and faster rebuilds
  • Docker build arguments to define node, go and alpine versions
  • Dockerfile org.opencontainers.image style labels
  • HTTP server based on a statically built Go binary HTTP server (high performance, small and one line in Dockerfile)
  • Runs as user ID 1000 without root, for security purposes

This was referenced Oct 29, 2019
@knsv knsv merged commit 4d1739c into mermaidjs:master Nov 17, 2019
@qdm12
Copy link
Contributor Author

qdm12 commented Nov 17, 2019

Just noticed I forgot to remove my email address from the Dockerfile as author org.opencontainers.image.authors you may want to add yours or change mine to yours if you want. I don't mind of course, but you're more the author than me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants