Change "PHP" to "php" for Travis. Add a few tests.

mermshaus · Mar 25, 2016 · 00b539e · 00b539e
1 parent e12d414
commit 00b539e
Show file tree

Hide file tree

Showing 3 changed files with 47 additions and 4 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -4,7 +4,7 @@ sudo: false
 
 matrix:
   include:
-    - PHP: 5.3
+    - php: 5.3
     - php: 5.4
     - php: 5.5
     - php: 5.6

diff --git a/src/PathHelper.php b/src/PathHelper.php
@@ -11,8 +11,17 @@
 
 use InvalidArgumentException;
 
+/**
+ *
+ */
 final class PathHelper
 {
+    /**
+     *
+     * @param string $path
+     * @return string
+     * @throws InvalidArgumentException
+     */
     public function normalizeDirectorySeparators($path)
     {
         if (!is_string($path)) {
@@ -21,8 +30,11 @@ public function normalizeDirectorySeparators($path)
 
         $directorySeparatorInverse = (DIRECTORY_SEPARATOR === '/') ? '\\' : '/';
 
-        return str_replace($directorySeparatorInverse, DIRECTORY_SEPARATOR,
-                $path);
+        return str_replace(
+            $directorySeparatorInverse,
+            DIRECTORY_SEPARATOR,
+            $path
+        );
     }
 
     /**

diff --git a/tests/Kaloa/Tests/Filesystem/PathHelperTest.php b/tests/Kaloa/Tests/Filesystem/PathHelperTest.php
@@ -12,8 +12,14 @@
 use Kaloa\Filesystem\PathHelper;
 use PHPUnit_Framework_TestCase;
 
+/**
+ *
+ */
 class PathHelperTest extends PHPUnit_Framework_TestCase
 {
+    /**
+     *
+     */
     public function testNormalize()
     {
         $ph = new PathHelper();
@@ -66,7 +72,10 @@ public function testNormalize()
         $this->assertEquals('/',          $f('  \\.\\dir1\\.\\dir2\\\\\\..\\..\\..\\\\\\ '));
     }
 
-    public function testNormalize_Additional()
+    /**
+     *
+     */
+    public function testNormalizeAdditional()
     {
         $ph = new PathHelper();
 
@@ -76,4 +85,26 @@ public function testNormalize_Additional()
 
         $this->assertEquals('dir1', $f($f('./dir1/.//') . '/' . $f('dir2/../dir3//dir4/.././/..')));
     }
+
+    /**
+     *
+     */
+    public function testNormalizeThrowsException()
+    {
+        $this->setExpectedException('InvalidArgumentException');
+
+        $ph = new PathHelper();
+        $ph->normalize(42);
+    }
+
+    /**
+     *
+     */
+    public function testNormalizeDirectorySeparatorsThrowsException()
+    {
+        $this->setExpectedException('InvalidArgumentException');
+
+        $ph = new PathHelper();
+        $ph->normalizeDirectorySeparators(42);
+    }
 }