Client optimization to open wsdl connection only when "find" method i…

…s called.
merorafael · Jun 3, 2017 · 14c8a73 · 14c8a73
1 parent 1498da9
commit 14c8a73
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 26 deletions.
diff --git a/src/Mero/Correios/Client.php b/src/Mero/Correios/Client.php
@@ -8,22 +8,12 @@
 
 class Client
 {
-    /**
-     * @var \SoapClient Correios WSDL Client
-     */
-    protected $wsdlClient;
-
-    public function __construct()
-    {
-        $this->wsdlClient = $this->createSoapClient();
-    }
-
     /**
      * Return the Correios SOAP client.
      *
      * @return \SoapClient SOAP client
      */
-    protected function createSoapClient()
+    protected function createWsdlConnection()
     {
         return new \SoapClient(
             "https://apps.correios.com.br/SigepMasterJPA/AtendeClienteService/AtendeCliente?wsdl"
@@ -47,7 +37,8 @@ public function findAddressByZipCode($zipCode)
             throw new InvalidZipCodeException('The brazilian zip code should have exacly 8 characters.');
         }
         try {
-            $address = $this->wsdlClient->__soapCall('consultaCEP', [
+            $wsdlConnection = $this->createWsdlConnection();
+            $address = $wsdlConnection->__soapCall('consultaCEP', [
                 'consultaCEP' => [
                     'cep' => $zipCode
                 ]

diff --git a/tests/Mero/Correios/ClientTest.php b/tests/Mero/Correios/ClientTest.php
@@ -55,18 +55,13 @@ protected function createClientMock($soapClientMocked)
     {
         $client = $this
             ->getMockBuilder(Client::className())
-            ->disableOriginalConstructor()
-            ->setMethods(["createSoapClient"])
+            ->setMethods(["createWsdlConnection"])
             ->getMock();
 
         $client
-            ->method("createSoapClient")
+            ->method("createWsdlConnection")
             ->willReturn($soapClientMocked);
 
-        $reflectedClass = new \ReflectionClass(Client::className());
-        $constructor = $reflectedClass->getConstructor();
-        $constructor->invoke($client, []);
-
         return $client;
     }
 
@@ -75,8 +70,8 @@ protected function createClientMock($soapClientMocked)
      */
     public function testInvalidZipCodeException()
     {
-        $wsdlClient = $this->createSoapClientMock();
-        $client = $this->createClientMock($wsdlClient);
+        $wsdlConnection = $this->createSoapClientMock();
+        $client = $this->createClientMock($wsdlConnection);
         $client->findAddressByZipCode("200430900");
     }
 
@@ -85,12 +80,12 @@ public function testInvalidZipCodeException()
      */
     public function testAddressNotFoundException()
     {
-        $wsdlClient = $this
+        $wsdlConnection = $this
             ->getMockBuilder("\SoapClient")
             ->disableOriginalConstructor()
             ->getMock();
 
-        $wsdlClient
+        $wsdlConnection
             ->method("__soapCall")
             ->willThrowException(new \SoapFault(
                 "soap:Server",
@@ -101,14 +96,14 @@ public function testAddressNotFoundException()
                 ]
             ));
 
-        $client = $this->createClientMock($wsdlClient);
+        $client = $this->createClientMock($wsdlConnection);
         $client->findAddressByZipCode("20000000");
     }
 
     public function testFindAddressByZipCode()
     {
-        $wsdlClient = $this->createSoapClientMock();
-        $client = $this->createClientMock($wsdlClient);
+        $wsdlConnection = $this->createSoapClientMock();
+        $client = $this->createClientMock($wsdlConnection);
         $address = $client->findAddressByZipCode("22640102");
         $this->assertEquals("Avenida das Américas", $address->getAddress());
         $this->assertEquals("Barra da Tijuca", $address->getNeighborhood());