the dark / light switch on demo website should be instant.

[delata]

it takes more than a seconds. and lags. it should me smooth.

[ghost]

@delata It seems to be instantaneous for me on the latest versions of Chrome, Firefox, and Safari on MacOS. Would you mind showing a video?

[delata]

i am using chrome ( actually Brave) on android running on a 3 years old 75 dollar phone.

[delata]

again you are running on a macbook.
yes on my laptop lag is less noticeable.
test this on a low powered phone.

[Anachron]

I'm running it on a Samsung Galaxy A40 which costes $150 when it was new a year ago but it takes at most a second to change.

Are you sure it is not causes by addons or other applications slowing down your phone?

Also I'm running it on firefox, maybe try that as well.

[delata]

this is a problem, i have used other websites that had this kind of mechanism, but they were smooth on my phone.

[Anachron]

Were they also written in react or just switched stylesheets?

[delata]

i don't know, they were simple website. the whole react thing is a garbage. worse thing is that people are now using it every where.

[ghost]

@delata I see what you're talking about: 6x Slowed CPU + 3G, but I believe this is just the result of making large changes to the DOM on slower devices, which is why you don't notice it on other websites. I think a solution could be to maybe make the opposite version (dark/light) hidden instead of completely removed from the DOM; however, this feels like an edge case.

[ghost]

Were they also written in react or just switched stylesheets?

They're two separate React components which are removed and added with the switch, which causes quite a bit of distress to the CPU, etc.. Only around ten CSS classes are changed, so I can see possible merging these two components into one, but it will reduce readability of the source code.

[Anachron]

Were they also written in react or just switched stylesheets?

They're two separate React components which are removed and added with the switch, which causes quite a bit of distress to the CPU, etc.. Only around ten CSS classes are changed, so I can see possible merging these two components into one, but it will reduce readability of the source code.

I was talking about the other websites, if they were switching stylesheets or also are written in react. I am well aware how this library handles it, given that I've read the source code.

[ghost]

@Anachron Sorry, I guess I misread it.